Skip to content

Define Linking ABI for common symbols#267

Open
dschuff wants to merge 1 commit into
mainfrom
common-symbol
Open

Define Linking ABI for common symbols#267
dschuff wants to merge 1 commit into
mainfrom
common-symbol

Conversation

@dschuff
Copy link
Copy Markdown
Member

@dschuff dschuff commented May 22, 2026

As discussed in llvm/llvm-project#196641

So far there is not support for initialized common symbols.

As discussed in llvm/llvm-project#196641
So far there is not support for initialized common symbols.
@dschuff dschuff requested a review from sbc100 May 22, 2026 00:44
@dschuff
Copy link
Copy Markdown
Member Author

dschuff commented May 22, 2026

I have an implementation which I will post shortly.

@sbc100 This version uses the combined bitmask of BINDING_GLOBAL and BINDING_WEAK (which are mutually exclusive) to mean BINDING_COMMON. Do you think this is better than just allocating another bit at the end?

@sbc100
Copy link
Copy Markdown
Member

sbc100 commented May 22, 2026

Combining BINDING_GLOBAL and BINDING_WEAK makes some logical sense to me.

But I don't quite understand since WASM_SYM_BINDING_GLOBAL is zero how can you know if its included in the bitmask along with WASM_SYM_BINDING_WEAK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants